Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Migrate towards ljsonv3 #24

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: Migrate towards ljsonv3 #24

wants to merge 4 commits into from

Conversation

gabrielcowley
Copy link

@gabrielcowley gabrielcowley commented Feb 24, 2017

The issue which explains the migration that this PR contributes to can be found here: https://github.com/menpo/landmarker.io/wiki/LEP-0001:-LJSON-v3

This has not been properly tested yet - landmarkerio-server depends on the menpo library which has a ljsonv3 migration PR (https://github.com/menpo/menpo/pull/785 ) and this is currently a WIP.

@gabrielcowley
Copy link
Author

Testing has been done against the latest commit on the ljsonv3 menpo PR (menpo/menpo#785) and it seems to be working now. image and mesh mode have both been tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants